git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] revision.c: really honor --first-parent

From
LHLars Hjemli <hjemli@gmail.com>
Date
May 14, 2008, 10:54 UTC
Message-ID
<8c5c35580805140354s62301343n62f8319b1853bfbd@mail.gmail.com>
In-Reply-To
<20080514103454.GA28610@cuci.nl>
On Wed, May 14, 2008 at 12:34 PM, Stephen R. van den Berg <srb@cuci.nl> wrote:
Show 6 quoted lines
>  So, I'd say, since the current code does not and cannot work reliably
>  for anyone specifically using --first-parent (with every merge
>  encountered, the probability of correctness is multiplied by 0.5 at
>  most/least), you are going to do them a favour anyway by fixing the code,
>  then why not simplify the convolution and make the code rock-steady (and
>  implement my patch)?

The current 'next' branch in git.git contains your patch with my fixup on top and I believe this fixes _both_ the original issue with first-parent (thanks to your patch) and the issue Nanako discovered (thanks to my patch). Am I missing something?

-- 
larsh
Previous: Stephen R. van den BergNext: Stephen R. van den Berg
Message 9 of 10 in “"git log --first-parent" shows parents that are not first”
  1. しらいしななこMay 11, 2008
  2. Junio C HamanoMay 11, 2008
  3. revision.c: really honor --first-parentLars Hjemli, May 11, 2008
  4. revision.c: really honor --first-parentLars Hjemli, May 12, 2008
  5. Stephen R. van den BergMay 13, 2008
  6. Lars HjemliMay 13, 2008
  7. Junio C HamanoMay 13, 2008
  8. Stephen R. van den BergMay 14, 2008
  9. Lars HjemliMay 14, 2008
  10. Stephen R. van den BergMay 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.