Re: XML parsing error from gitweb at freedesktop.org

From: Lars Hjemli <hjemli@gmail.com>
Date: Dec 6, 2007, 22:11 UTC
Message-ID: <8c5c35580712061411k7a40a08el35f31c43add25cb3@mail.gmail.com>
In-Reply-To: <799406d60712061334q33d2dba5r5496ba21069a4547@mail.gmail.com>

On Dec 6, 2007 10:34 PM, Adam Mercer <ramercer@gmail.com> wrote:

Show 7 quoted lines

> as cgit displays the commit OK
>
> <http://cgit.freedesktop.org/xorg/xserver/commit/?h=xorg-server-1.2-apple&id=48e6a75fbdd0fee86e364f02ace83f20b312a2b2>
>
> leads me to think that the problem lies in gitweb.  Could this be a
> problem with gitweb?
>

Actually, it's a problem in both cgit and gitweb, but you need to look a bit harder to find the error in cgit. It seems that gitweb on freedesktop.org doesn't detect a file rename (due to diff.renamelimit maybe?), so it shows the full source of the offending files, while in cgit you'll need to go from the diff to either the old or the new sourcefile to get the same error:

http://cgit.freedesktop.org/xorg/xserver/tree/hw/darwin/quartz/applewmExt.h?h=xorg-server-1.2-apple&id=141f69dc3d8d6e7d8ff65607f43700ac11243041 http://cgit.freedesktop.org/xorg/xserver/diff/hw/xquartz/applewm.c?h=xorg-server-1.2-apple&id=48e6a75fbdd0fee86e364f02ace83f20b312a2b2

The problem is a number of unencoded ascii char 12.

-- larsh