Re: [PATCH] git-svn: remove --first-parent, add --upstream

From: Lars Hjemli <hjemli@gmail.com>
Date: Sep 6, 2007, 22:14 UTC
Message-ID: <8c5c35580709061514n1de6f141v5e596074cfa9fb42@mail.gmail.com>
In-Reply-To: <20070906213556.GA21234@soma>

On 9/6/07, Eric Wong <normalperson@yhbt.net> wrote:

> Wait, actually.  --upstream won't ever populate the refs array in
> working_head_info for dcommit

Sorry, I didn't realize that working_head_info() collected commit-ids later used by dcommit. But to implement --upstream we could maybe do something like this:

sub working_head_info {
  my ($head, $refs) = @_;

  if (defined $_upstream) {
    working_head_info_traverse($head, \$refs);
    return working_head_info_traverse($_upstream, undef);
  }

  return working_head_info_traverse($head, \$refs);
}

sub working_head_info_traverse {
  my ($head, $refs) = @_;
  my ($fh, $ctx) = command_output_pipe('log', '--no-color',
'--first-parent', $head);
  ...

(This was written straight into firefox, late at night, by a perl illiterate. Please be gentle...)

-- 
larsh