Re: [PATCH] unpack-trees.c: assume submodules are clean during check-out

From: Lars Hjemli <hjemli@gmail.com>
Date: Aug 4, 2007, 11:41 UTC
Message-ID: <8c5c35580708040441ue1c3ef8qc022912a5af4883e@mail.gmail.com>
In-Reply-To: <7v643vj316.fsf@assigned-by-dhcp.cox.net>

On 8/4/07, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> As we explicitly allow
> submodule checkout to drift from the supermodule index entry,
> the check should say "Ok, for submodules, not matching is the
> norm" for now.  Later when we have the ability to mark "I care
> about this submodule to be always in sync with the superproject"
> (thereby implementing automatic recursive checkout and perhaps
> diff, among other things), we should check if the submodule in
> question is marked as such and perform the current test.

Yes, this sounds like a sane plan (and a good explanation of the current semantics: maybe something to include in the release notes for 1.5.3?)

Btw: I've applied your patch to rc-4 and tested the result in my cgit
repo: very nice, and very ack'd ;-)

-- larsh