Re: [PATCH] Let .git/config specify the url for submodules

From: Lars Hjemli <hjemli@gmail.com>
Date: Jun 1, 2007, 14:45 UTC
Message-ID: <8c5c35580706010745l76fc5410l21f2e3f385693ad9@mail.gmail.com>
In-Reply-To: <20070601093554.GV955MdfPADPa@greensroom.kotnet.org>

On 6/1/07, Sven Verdoolaege <skimo@kotnet.org> wrote:

Show 12 quoted lines

> On Fri, Jun 01, 2007 at 11:25:42AM +0200, Lars Hjemli wrote:
> > On 6/1/07, Sven Verdoolaege <skimo@kotnet.org> wrote:
> > >Could you please document the proposed .gitmodules first?
> >
> > The man-page for git-submodule found in 'next' mentions how it uses
> > .gitmodules, but there isn't (yet) a separate man-page for
> > .gitmodules(5).
>
> That's what I'd like to see first.
> .gitmodules(5) will hopefully not change in an incompatible
> way after it is accepted, while there is no such constraint
> for git-submodule.

True

Show 16 quoted lines

>
> > [path '$path']
> >  submodule=modulename
> >  url=/some/url
>
> Wouldn't it make more sense to have
>
> [path '$path']
>         submodule=modulename
>
> and
>
> [submodule '$modulename']
>         url=/some/url
>
> in case the same module appears in more than one path?

Yes, that would be a properly normalized model.

Hmm.... Maybe we could allow both variations, with your suggestion overriding mine if both are present? (I think there would be many cases where the extra level of [submodule...] wouldn't be needed. Also, the url in .gitmodules will only function as the initially suggested url stored in the 'superprojects' .git/config)

-- larsh