Re: [PATCH v2 0/3] Feature: New Variable git-p4.p4program
- From
Ben Keene <seraphire@gmail.com>
- Date
- Dec 3, 2019, 15:59 UTC
- Message-ID
- <8b1329db-edd7-496f-1328-7cd249b19451@gmail.com>
- In-Reply-To
- <xmqqeey63ryq.fsf@gitster-ct.c.googlers.com>
On 11/17/2019 8:15 PM, Junio C Hamano wrote:
Show 15 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> As to individual patches, our local (read: project specific) >> convention around here is to state the are the patch touches (in the >> case of these patches, "git-p4" is the appropriate area name), colon, >> and then a one-line summary of what the step is about (the last one >> is done without initial capitalization). The summary is written with >> the focus more on why and what than how. > > Sorry for a late typofix. "to state the AREA the patch touches" was > what I meant. So I would expect all patches to this file (which is > the only component of 'git-p4' subsystem) to begin with "git-p4: " > prefix. > > Thanks.
I was having email trouble trying to reply to your suggestions. (Downloaded yet another mail client, and this seems to work) I'll make those changes.