git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 12/12] t5318: use test_oid for HASH_LEN

From
Derrick Stolee <stolee@gmail.com>
Date
Sep 4, 2018, 12:36 UTC
Message-ID
<8af735dc-99cd-f297-415f-24e53ea77344@gmail.com>
In-Reply-To
<20180903232515.336397-13-sandals@crustytoothpaste.net>
On 9/3/2018 7:25 PM, brian m. carlson wrote:
Show 20 quoted lines
> From: Derrick Stolee <stolee@gmail.com>
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>   t/t5318-commit-graph.sh | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> index 3c1ffad491..d286516f0e 100755
> --- a/t/t5318-commit-graph.sh
> +++ b/t/t5318-commit-graph.sh
> @@ -8,7 +8,8 @@ test_expect_success 'setup full repo' '
>   	cd "$TRASH_DIRECTORY/full" &&
>   	git init &&
>   	git config core.commitGraph true &&
> -	objdir=".git/objects"
> +	objdir=".git/objects" &&
> +	test_oid_init
>   '
Ah yes, thanks for adding this.
Show 11 quoted lines
>   
>   test_expect_success 'verify graph with no graph file' '
> @@ -273,7 +274,7 @@ test_expect_success 'git commit-graph verify' '
>   
>   NUM_COMMITS=9
>   NUM_OCTOPUS_EDGES=2
> -HASH_LEN=20
> +HASH_LEN="$(test_oid rawsz)"
>   GRAPH_BYTE_VERSION=4
>   GRAPH_BYTE_HASH=5
>   GRAPH_BYTE_CHUNK_COUNT=6
Previous: brian m. carlsonNext: Duy Nguyen
Message 16 of 18 in “Hash-independent tests (part 3)”
  1. 00/12 Hash-independent tests (part 3)brian m. carlson, Sep 3, 2018
  2. 02/12 t0000: use hash translation tablebrian m. carlson, Sep 3, 2018
  3. 01/12 t: add test functions to translate hash-related valuesbrian m. carlson, Sep 3, 2018
  4. Eric SunshineSep 4, 2018
  5. brian m. carlsonSep 5, 2018
  6. 03/12 t0000: update tests for SHA-256brian m. carlson, Sep 3, 2018
  7. 05/12 t0027: make hash size independentbrian m. carlson, Sep 3, 2018
  8. 06/12 t0064: make hash size independentbrian m. carlson, Sep 3, 2018
  9. 04/12 t0002: abstract away SHA-1 specific constantsbrian m. carlson, Sep 3, 2018
  10. 07/12 t1006: make hash size independentbrian m. carlson, Sep 3, 2018
  11. 08/12 t1400: switch hard-coded object ID to variablebrian m. carlson, Sep 3, 2018
  12. 09/12 t1405: make hash size independentbrian m. carlson, Sep 3, 2018
  13. 10/12 t1406: make hash-size independentbrian m. carlson, Sep 3, 2018
  14. 11/12 t1407: make hash size independentbrian m. carlson, Sep 3, 2018
  15. 12/12 t5318: use test_oid for HASH_LENbrian m. carlson, Sep 3, 2018
  16. Derrick StoleeSep 4, 2018
  17. Duy NguyenSep 4, 2018
  18. Junio C HamanoSep 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.