Re: [PATCHv2] clone: support cloning full bundles

From: Santi Béjar <sbejar@gmail.com>
Date: Feb 25, 2008, 20:29 UTC
Message-ID: <8aa486160802251229x778c7427nd51093bc23ec6c8c@mail.gmail.com>
In-Reply-To: <7vlk58j0k1.fsf@gitster.siamese.dyndns.org>

On Mon, Feb 25, 2008 at 8:30 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Santi Béjar <sbejar@gmail.com> writes:
>
>  > Signed-off-by: Santi Béjar <sbejar@gmail.com>
>  > ---
>  >
>  > Hi *,
>  >
>  >   while waiting for the C port of git-clone I've updated my patch to
>  > support bundles in "git clone".
>
>  I do not recall the v1 round of this patch, but it does not look
>  too bad.

Well, it was during the freeze, you probably had more important things to do :-)

http://article.gmane.org/gmane.comp.version-control.git/68035

Show 6 quoted lines

>
>  I was hoping, however, if we can replace "git fetch-pack" there
>  with "git-fetch" so that you do not have to have the if
>  conditional based on "$repo"'s type.  Isn't "git fetch" capable
>  of fetching from a bundle already?
>

"git fetch" is capable to fetch bundles, but to use "git fetch" instead of "git fetch-pack" you need to reorganize other things (not the same output, to download all the refs you need to write a config with refs/heads/*:..., "git fetch" does not have a --no-progress), so I opted for a minimal path (and not break the most used path :-).

I sent another patch to convert every transport to "git fetch" in:

http://article.gmane.org/gmane.comp.version-control.git/65669

but it had some problems (ups now I see I didn't answer to Johannes Schindelin's reply, sorry, or I cannot find it). At the end as git-clone was going to be ported to C...

Santi