Re: [PATCH 2/3] git-fetch: Support the local remote "."
- From
- Santi Béjar <sbejar@gmail.com>
- Date
- Mar 13, 2007, 23:01 UTC
- Message-ID
- <8aa486160703131601j19c4e3b2nd0a4e8ccd4cc7114@mail.gmail.com>
- In-Reply-To
- <45F6D718.5080601@lu.unisi.ch>
On 3/13/07, Paolo Bonzini <paolo.bonzini@lu.unisi.ch> wrote:
Show 19 quoted lines
> Santi Béjar wrote: > > To this end, git-parse-remote is grown with a new kind of remote, > > `builtin'. This returns all the local branches in > > get_remote_default_refs_for_fetch. This is equivalent to having a > > fake remote as: > > > > [remote "local"] > > url = . > > fetch = refs/* > > > > Based on a patch from Paolo Bonzini. > > Can you please compare the times to do "git fetch ."? The reason > to touch git-fetch.sh was an optimization that Junio requested. > > I found my 2nd submission to be 20% faster than the first. > > Paolo >
Yes. But this optimization is independent of this patch, as it already exists without this (but it gets worse with this patch).
Also, I think, the split in fetch_main should be base on transport and not on the definition of the remote.
Santi