Re: [PATCH 7/6] format-patch: fix leak of empty header string

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Mar 22, 2024, 10:03 UTC
Message-ID: <8a4d6e5e-5640-4230-8651-8e0846b383fd@app.fastmail.com>
In-Reply-To: <20240322095951.GA529578@coredump.intra.peff.net>

On Fri, Mar 22, 2024, at 10:59, Jeff King wrote:

Show 21 quoted lines

> On Tue, Mar 19, 2024 at 08:25:55PM -0400, Jeff King wrote:
>
>>   [1/6]: shortlog: stop setting pp.print_email_subject
>>   [2/6]: pretty: split oneline and email subject printing
>>   [3/6]: pretty: drop print_email_subject flag
>>   [4/6]: log: do not set up extra_headers for non-email formats
>>   [5/6]: format-patch: return an allocated string from log_write_email_headers()
>>   [6/6]: format-patch: simplify after-subject MIME header handling
>
> These patches introduce a small leak into format-patch. I didn't notice
> before because the "leaks" CI jobs were broken due to sanitizer problems
> in the base image (which now seem fixed?).
>
> Here's a fix that can go on top of jk/pretty-subject-cleanup. That topic
> is not in 'next' yet, so I could also re-roll. The issue was subtle
> enough that a separate commit is not such a bad thing, but I'm happy to
> squash it in if we'd prefer.
>
> -- >8 --
> Subject: [PATCH] format-patch: fix leak of empty header string
> [snip]

Hi Peff, and thanks a lot for making this series.

I’ll have a look at it this evening.

Thanks

-- 
Kristoffer Haugsbakk