git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] imap-send: parse default git config

From
Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Date
Nov 25, 2020, 08:05 UTC
Message-ID
<8a21b031-fbfd-81c2-1f91-eff8c03bafb7@suse.com>
In-Reply-To
<76d2be10-0c42-70f4-101c-ee15e3039821@gmail.com>

git imap-send does not parse the default git config settings and thus ignore core.askpass value. Fix it by calling git_config(git_default_config)

Reported-by: Philippe Blain <levraiphilippeblain@gmail.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
---
  imap-send.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/imap-send.c b/imap-send.c
index 5764dd812ca7..790780b76da2 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1367,6 +1367,7 @@ static void git_imap_config(void)
  	git_config_get_int("imap.port", &server.port);
  	git_config_get_string("imap.tunnel", &server.tunnel);
  	git_config_get_string("imap.authmethod", &server.auth_method);
+	git_config(git_default_config, NULL);
  }
  
  static int append_msgs_to_imap(struct imap_server_conf *server,
-- 
2.29.2.366.gb291b0a62802
Previous: Philippe BlainNext: Junio C Hamano
Message 2 of 5 in “[BUG] git imap-send does not honor 'core.askpass'”
  1. Philippe BlainNov 24, 2020
  2. imap-send: parse default git configNicolas Morey-Chaisemartin, Nov 25, 2020
  3. Junio C HamanoNov 25, 2020
  4. Nicolas Morey-ChaisemartinNov 25, 2020
  5. Junio C HamanoNov 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.