Re: Extending whitespace checks
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Nov 24, 2024, 21:58 UTC
- Message-ID
- <89b1b39c-a6d2-4f63-9cc5-722772bddd8a@app.fastmail.com>
- In-Reply-To
- <D5UQHS9IV5N1.3IO1848Q1730B@ferdinandy.com>
On Sun, Nov 24, 2024, at 22:41, Bence Ferdinandy wrote:
Show 9 quoted lines
> This might be a tangent, but since enhancing whitespace checking was mentioned, > I'd thought I note here: `git log --check` running in the CI did not catch the > white space errors in this patch (see the last hunk): > > https://lore.kernel.org/git/20241121225757.3877852-4-bence@ferdinandy.com/ > > although it would have been certainly nice. I'm not sure if --check could > already catch this actually, or if it would be easy/possible to have something > general enough that does catch it.
It looks like you indented some lines with spaces instead of tabs. It doesn’t look like a “whitespace error” in the `--check` sense as I understand it.