git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Weird revision walk behaviour

From
Kevin Bracey <kevin@bracey.fi>
Date
May 24, 2018, 18:54 UTC
Message-ID
<88f96a35-6368-de24-60ed-ad015f16f127@bracey.fi>
In-Reply-To
<20180523173523.GB10299@sigill.intra.peff.net>
On 23/05/2018 20:35, Jeff King wrote:
Show 5 quoted lines
> There's more discussion in the thread at:
>
>    https://public-inbox.org/git/1366658602-12254-1-git-send-email-kevin@bracey.fi/
>
> I haven't absorbed it all yet, but I'm adding Junio to the cc.

Just to ack that I've seen the discussion, but I can't identify the code's reasoning at the moment. My recollection is that I accepted while coming up with the algorithm that it might err slightly on the side of false positives in the display - there were some merge cases I was unable to fully distinguish whether or not the merge had lost a change it shouldn't have done, and if I was uncertain I'd rather show it than not.

The first commit was not originally intended to alter behaviour for anything other than --full-history, but later in the chain there was specific consideration into tracking the path to the specified "bottom" commit. It may be that's part of what's happening here.

Kevin
Previous: Jeff KingNext: Kevin Bracey
Message 4 of 12 in “Weird revision walk behaviour”
  1. SZEDER GáborMay 23, 2018
  2. Jeff KingMay 23, 2018
  3. Jeff KingMay 23, 2018
  4. Kevin BraceyMay 24, 2018
  5. Kevin BraceyMay 24, 2018
  6. Kevin BraceyMay 27, 2018
  7. SZEDER GáborMay 28, 2018
  8. Kevin BraceyMay 29, 2018
  9. Jeff KingMay 29, 2018
  10. Kevin BraceyMay 30, 2018
  11. Jeff KingMay 31, 2018
  12. Kevin BraceyMay 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.