Re: Bug?: git archive exclude pathspec and gitattributes export-ignore

From: René Scharfe <l.s.r@web.de>
Date: Aug 19, 2017, 05:26 UTC
Message-ID: <887652a4-3f03-e2dd-2c68-cff4f7194898@web.de>
In-Reply-To: <ae893c19-652d-1c8f-50ba-1242b95be84e@web.de>

Am 14.08.2017 um 18:43 schrieb René Scharfe:

> The real solution is probably to teach tree-walk.c::do_match() how to
> handle attributes and then inject ":(attr:-export-ignore)" as a default
> internal pathspec in archive.c::parse_pathspec_arg() instead of handling
> it in archive.c::write_archive_entry().

That's complicated and I'm not sure anymore if it's even a good idea. Let's solve this in git archive for now.

  t5001: add tests for export-ignore attributes and exclude pathspecs
  archive: factor out helper functions for handling attributes
  archive: don't queue excluded directories
  archive: queue directories for all types of pathspecs

 archive.c               | 49 +++++++++++++++++++++++++++++++++++++++++--------
 t/t5001-archive-attr.sh | 47 ++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 85 insertions(+), 11 deletions(-)

-- 
2.14.1