[PATCH v2 5/5] t/lib-commit-graph.sh: avoid sub-shell in `graph_git_behavior()`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Jul 24, 2023, 16:39 UTC
- Message-ID
- <887006eab461908493d377c042dd1b7e74641170.1690216758.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1690216758.git.me@ttaylorr.com>
In a previous commit, we introduced a sub-shell in the implementation of `graph_git_behavior()`, in order to allow us to pass `-C "$DIR"` directly to the git processes spawned by `graph_git_two_modes()`.
Now that its callers are always operating from the "$TRASH_DIRECTORY" instead of one of its sub-directories, we can drop the inner sub-shell, as it is no longer required.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- t/lib-commit-graph.sh | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/t/lib-commit-graph.sh b/t/lib-commit-graph.sh index c8bd76a7777..89b26676fbb 100755 --- a/t/lib-commit-graph.sh +++ b/t/lib-commit-graph.sh @@ -27,14 +27,11 @@ graph_git_behavior() { BRANCH=$3 COMPARE=$4 test_expect_success "check normal git operations: $MSG" ' - ( - cd "$TRASH_DIRECTORY" && - graph_git_two_modes "${DIR:+-C $DIR} log --oneline $BRANCH" && - graph_git_two_modes "${DIR:+-C $DIR} log --topo-order $BRANCH" && - graph_git_two_modes "${DIR:+-C $DIR} log --graph $COMPARE..$BRANCH" && - graph_git_two_modes "${DIR:+-C $DIR} branch -vv" && - graph_git_two_modes "${DIR:+-C $DIR} merge-base -a $BRANCH $COMPARE" - ) + graph_git_two_modes "${DIR:+-C $DIR} log --oneline $BRANCH" && + graph_git_two_modes "${DIR:+-C $DIR} log --topo-order $BRANCH" && + graph_git_two_modes "${DIR:+-C $DIR} log --graph $COMPARE..$BRANCH" && + graph_git_two_modes "${DIR:+-C $DIR} branch -vv" && + graph_git_two_modes "${DIR:+-C $DIR} merge-base -a $BRANCH $COMPARE" ' }
-- 2.41.0.399.g887006eab46