Re: [PATCH] send-email: support NNTP

From: Thomas Rast <trast@inf.ethz.ch>
Date: Apr 24, 2013, 07:38 UTC
Message-ID: <87zjwofken.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1366715634-21790-1-git-send-email-l.stelmach@samsung.com>

Łukasz Stelmach <l.stelmach@samsung.com> writes:

> Enable sending patches to NNTP servers (Usenet, Gmane).

I'm surprised Junio didn't mention this: your patch lacks the Signed-off-by.

Show 5 quoted lines

> +	if ($email_protocol eq 'nntp') {
> +		$header = "Newsgroups: $to\n" . $header;
> +	} else {
> +		$header = "To: $to${ccline}\n" . $header;
> +	}

Are you silently ignoring any Ccs that have been set if you're in NNTP mode?

Would it be possible to instead send the Ccs by mail as usual, and only the main message over NNTP? (You don't need to run off and implement this, but I'm curious how hard you think it would be.)

At least in the git@vger world with a lot of etiquette surrounding the use of Ccs, NNTP mode isn't very useful if you can't also send Ccs. But maybe you have another use-case where that is not a problem?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch