git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] fix blame -L regression; add tests

From
Thomas Rast <tr@thomasrast.ch>
Date
Jul 18, 2013, 12:04 UTC
Message-ID
<87zjtk6pmo.fsf@linux-k42r.v.cablecom.net>
In-Reply-To
<1374096332-7891-1-git-send-email-sunshine@sunshineco.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 21 quoted lines
> This series fixes a regression in "blame -L X,-N", adds blame -L tests,
> and makes minor documentation adjustments. The tests, in particular,
> were motivated by the desire to revisit and continue working on [1]
> which extends git-blame to accept multiple -L's. That topic will need to
> extend blame -L tests, of which there were essentially none.
>
> Patches [2/6] (modernize style) and [3/6] (add blame -L tests) are
> intentionally independent of the "git log -L" topic (from earlier this
> year) to which the other patches are related.  This independence should
> allow these two patches to graduate at their own pace without being tied
> to "git log -L".
>
> [1]: http://thread.gmane.org/gmane.comp.version-control.git/229755/
>
> Eric Sunshine (6):
>   line-range: fix "blame -L X,-N" regression
>   t8001/t8002 (blame): modernize style
>   t8001/t8002 (blame): add blame -L tests
>   t8001/t8002 (blame): add blame -L :funcname tests
>   blame-options.txt: place each -L option variation on its own line
>   blame-options.txt: explain that -L <start> and <end> are optional
Thanks, and except for the comment I just sent out,
Acked-by: Thomas Rast <trast@inf.ethz.ch>

In case it wasn't obvious to anyone else: the tests do actually verify that the right lines were picked, by counting how often each author is blamed.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Eric Sunshine
Message 12 of 12 in “fix blame -L regression; add tests”
  1. 0/6 fix blame -L regression; add testsEric Sunshine, Jul 17, 2013
  2. 1/6 line-range: fix "blame -L X,-N" regressionEric Sunshine, Jul 17, 2013
  3. 2/6 t8001/t8002 (blame): modernize styleEric Sunshine, Jul 17, 2013
  4. 3/6 t8001/t8002 (blame): add blame -L testsEric Sunshine, Jul 17, 2013
  5. 4/6 t8001/t8002 (blame): add blame -L :funcname testsEric Sunshine, Jul 17, 2013
  6. 5/6 blame-options.txt: place each -L option variation on its own lineEric Sunshine, Jul 17, 2013
  7. Thomas RastJul 18, 2013
  8. Junio C HamanoJul 18, 2013
  9. Thomas RastJul 22, 2013
  10. Junio C HamanoJul 22, 2013
  11. 6/6 blame-options.txt: explain that -L <start> and <end> are optionalEric Sunshine, Jul 17, 2013
  12. Thomas RastJul 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.