Re: git emacs mode patch

From: Alexandre Julliard <julliard@winehq.org>
Date: Mar 17, 2007, 10:04 UTC
Message-ID: <87y7lwxk2e.fsf@wine.dyndns.org>
In-Reply-To: <200703151403.56552.mega@retes.hu>

Gábor Melis <mega@retes.hu> writes:

> +(defcustom git-hide-unknown t
> +  "Hide files with unknown status by default."
> +  :group 'git
> +  :type 'boolean)

This one should default to nil for backwards compatibility.

Show 11 quoted lines

> @@ -1017,15 +1028,18 @@ and returns the process output as a string."
>        (with-temp-buffer
>          (git-run-command t nil "diff-index" "-z" "-M" "HEAD")
>          (git-parse-status status)))
> +    (unless (member 'up-to-date hidden-statuses)
>        (with-temp-buffer
> -        (git-run-command t nil "ls-files" "-z" "-u")
> -        (git-parse-ls-unmerged status))
> +        (git-run-command t nil "ls-files" "-z" "-t")
> +        (git-parse-ls-files status 'unknown)))
> +    (unless (member 'unknown hidden-statuses)

Why are you removing the ls-files -u? This will break the detection of unmerged files.

Show 5 quoted lines

> +(defun git-toggle-up-to-date ()
> +  (interactive)
> +  (if (member 'up-to-date hidden-statuses)
> +      (setq hidden-statuses (remove 'up-to-date hidden-statuses))
> +    (push 'up-to-date hidden-statuses))

The status should be named 'uptodate instead of 'up-to-date since that's what's used for individual files. Having two different spellings for the same word would be very confusing.

-- 
Alexandre Julliard
julliard@winehq.org