Re: [PATCH] git-am: don't ignore --keep (-k) option
- From
Jim Meyering <jim@meyering.net>
- Date
- Nov 27, 2009, 20:17 UTC
- Message-ID
- <87y6lr203s.fsf@meyering.net>
- In-Reply-To
- <7vy6lrka69.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 18 quoted lines
> Jim Meyering <jim@meyering.net> writes: >> I started looking at git-am.sh and spotted what appears to be a typo. >> There is only that one use of $keep_subject, so its value currently >> comes from the environment. >> >> From 02f7e6433b5db8b18a4cccf58c302159c2f54fa5 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering <meyering@redhat.com> >> Date: Wed, 25 Nov 2009 09:10:46 +0100 >> Subject: [PATCH] git-am: don't ignore --keep (-k) option >> >> Fix typo in variable name: s/keep_subject/keep/. >> >> Signed-off-by: Jim Meyering <meyering@redhat.com> > > At the level of "what does each line of the code do", this is a fix, but > as we do a lot more than just stripping "[PATCH] " from the beginning of > the Subject: line these days, I think we are better off declaring defeat > in this particular codepath and not doing anything here.
Sounds fine to me. Glad you're keeping everything in perspective.