help.autoCorrect prefix selection considered a bit dangerous
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Nov 19, 2018, 20:35 UTC
- Message-ID
- <87y39oztzf.fsf@evledraar.gmail.com>
- In-Reply-To
- <1290787239-4508-1-git-send-email-kusmabite@gmail.com>
Replying to this blast from the past: https://public-inbox.org/git/1290787239-4508-1-git-send-email-kusmabite@gmail.com/
I apparently like to live dangerously and have help.autoCorrect enabled. I just had:
git puss
Auto-corrected to:
git push
When I meant:
git pull
(For those wondering how I could have mistyped that, "l" and "s" are right next to each other on a Dvorak layout).
As seen in the E-Mail from 2010 this intentional, i.e. "pull" is pruned since the "pu" prefix isn't matched, but "pus" is. This was meant to correct e.g. "git st" to "git status".
I don't have time to poke at this now, but wonder if:
1) The correction facility shouldn't at least have a list of "this does
stuff over the wire" commands and would then use a more conservative
estimate. 2) Whether we can do better with typo detection. E.g. add commands like
"pull" to the list if we have a long enough prefix for them, and if
the number of characters entered matches the number of characters in
another command.