git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] upload-pack: Check for NOT_SHALLOW flag before sending a shallow to the client.

From
AJAlexandre Julliard <julliard@winehq.org>
Date
Nov 24, 2006, 14:58 UTC
Message-ID
<87wt5kuc1a.fsf@wine.dyndns.org>

A commit may have been put on the shallow list, and then reached from another branch and marked NOT_SHALLOW without being removed from the list.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 upload-pack.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/upload-pack.c b/upload-pack.c
index d5b4750..d4a7b62 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -565,7 +565,7 @@ static void receive_needs(void)
 			SHALLOW, NOT_SHALLOW);
 		while (result) {
 			struct object *object = &result->item->object;
-			if (!(object->flags & CLIENT_SHALLOW)) {
+			if (!(object->flags & (CLIENT_SHALLOW|NOT_SHALLOW))) {
 				packet_write(1, "shallow %s",
 						sha1_to_hex(object->sha1));
 				register_shallow(object->sha1);
-- 
1.4.4.1.ga335e

-- 
Alexandre Julliard
Message 1 of 1 in “upload-pack: Check for NOT_SHALLOW flag before sending a shallow to the client.”
  1. 2/5 upload-pack: Check for NOT_SHALLOW flag before sending a shallow to the client.Alexandre Julliard, Nov 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.