Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

From: Thomas Rast <trast@inf.ethz.ch>
Date: Apr 8, 2013, 21:25 UTC
Message-ID: <87wqscr9yk.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1365091293-23758-1-git-send-email-jkoleszar@google.com>

John Koleszar <jkoleszar@google.com> writes:

Show 5 quoted lines

> Filter the list of refs returned via the dumb HTTP protocol according
> to the active namespace, consistent with other clients of the
> upload-pack service.
>
> Signed-off-by: John Koleszar <jkoleszar@google.com>

At the risk of repeating something that's been said already -- I only skimmed the thread -- this test breaks in today's pu on my machine. I get:

expecting success: (
	log_div "namespace test"
	config http.uploadpack true &&
	config http.getanyfile true &&

	NS=ns &&
	(cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
		git update-ref refs/namespaces/$NS/refs/heads/master HEAD
	) &&

	SMART=smart
	git ls-remote public >expect &&
	grep /$NS/ expect &&
	GET_BODY "info/refs" >actual &&
	test_cmp expect actual &&
	GET_BODY "info/refs?service=git-upload-pack" >actual &&
	grep /$NS/ actual &&

	SMART=smart_namespace &&
	GIT_NAMESPACE=$NS && export GIT_NAMESPACE &&
	git ls-remote public >expect &&
	! grep /$NS/ expect &&
	GET_BODY "info/refs" >actual &&
	test_cmp expect actual &&
	GET_BODY "info/refs?service=git-upload-pack" >actual &&
	! grep /$NS/ actual
)
453190505bf07f7513bed9839da875eb3610f807	refs/namespaces/ns/refs/heads/master
--- expect	2013-04-08 21:24:36.571874540 +0000
+++ actual	2013-04-08 21:24:36.579874619 +0000

@@ -1,3 +1,2 @@
-453190505bf07f7513bed9839da875eb3610f807	HEAD
 453190505bf07f7513bed9839da875eb3610f807	refs/heads/master
 453190505bf07f7513bed9839da875eb3610f807	refs/namespaces/ns/refs/heads/master
not ok 14 - backend respects namespaces

-- 
Thomas Rast
trast@{inf,student}.ethz.ch