Re: [patch] gitignore: warn about pointless syntax

From: Thomas Rast <trast@student.ethz.ch>
Date: Jan 9, 2012, 13:44 UTC
Message-ID: <87vcolrnw2.fsf@thomas.inf.ethz.ch>
In-Reply-To: <alpine.LNX.2.01.1201091233050.28805@frira.zrqbmnf.qr>

Jan Engelhardt <jengelh@medozas.de> writes:

Show 6 quoted lines

> parent eac2d83247ea0a265d923518c26873bb12c33778 (v1.7.9-rc0)
> commit b629bde461aeb178b257ab7e0f6c180f69f98cb0
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date:   Mon Jan 9 12:30:07 2012 +0100
>
> gitignore: warn about pointless syntax

[...]

> -- 
> # Created with git-export-patch

Are you the author of this tool? The format is bogus in so far as it causes git-am to insert the above lines into the git commit message, as in:

    $ git am -3 < gitignore-patch.mbox
    Applying: gitignore: warn about pointless syntax
    $ git show
    commit 59bea4d9a1de3b3b9c0139de4298ffd9d9431457
    Author: Jan Engelhardt <jengelh@medozas.de>
    Date:   Mon Jan 9 12:34:12 2012 +0100

        gitignore: warn about pointless syntax
        
        parent eac2d83247ea0a265d923518c26873bb12c33778 (v1.7.9-rc0)
        commit b629bde461aeb178b257ab7e0f6c180f69f98cb0
        Author: Jan Engelhardt <jengelh@medozas.de>
        Date:   Mon Jan 9 12:30:07 2012 +0100
        
        gitignore: warn about pointless syntax
    [...]

So using this tool over format-patch is just a pointless cause of manual fixup work.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch