Re: Patchset NTLM-Authentication
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Feb 21, 2012, 09:22 UTC
- Message-ID
- <87vcn0h77a.fsf@thomas.inf.ethz.ch>
- In-Reply-To
- <4CDEC141B5583D408E79F2931DB7708301802B70@GSX300A.mxchg.m.corp>
"Schmidt, Marco" <Marco.Schmidt@cassidian.com> writes:
> I'm not conform with your patch submitting policy. I had no chance to > track the git repository from my current location.
You should read Documentation/SubmittingPatches. If your location does not let you use any git:// or git+http:// ("smart http") transports, you can use the wereHamster's bundler service https://bundler.caurea.org/ to get a bundle that you can download over http. (If you cannot download *anything* over http, what is your internet access good for?)
Looking at the attachments:
[0002-Einf-hren-der-HTTP-Proxy-Authentifizierung.patch] [0003-First-working-step.patch] [0004-remove-debug-information.patch]
* You seem to have forgotten the first patch. As it stands, the 0002 one does not apply to my tree.
* The commit messages are useless. The second one at least says "introduce HTTP proxy authentication" which tells me something about *what it does*, but in German. It should also tell me why and how and possible other considerations. See SubmittingPatches.
* The commits should "spring into perfect existence". That is, in the above you should squash 3 and 4 into 2 so that 2 starts out working (presumably -- I'm only looking at the subjects) . You can use rebase -i to clean everything up.
--
Thomas Rast
trast@{inf,student}.ethz.ch