git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Help needed on 2.54.0-rc0 t5301.13 looping.

From
Adrian Ratiu <adrian.ratiu@collabora.com>
Date
Apr 8, 2026, 17:01 UTC
Message-ID
<87v7e11j4q.fsf@collabora.com>
In-Reply-To
<xmqqcy091jht.fsf@gitster.g>
On Wed, 08 Apr 2026, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
> Adrian Ratiu <adrian.ratiu@collabora.com> writes:
>
>> Thanks Peff for the in-depth analysis, fix and test.
>> It is very much appreciated. I missed this case.
>>
>> I agree with your assesement: this must be fixed regardless if it also
>> fixes Randall's case or not (might be a separate root cause).
>>
>> I would proceed like this (obviously crediting you for the fix & test):
>>
>> If it fixes Randall's case:
>>    send a standalone bug-fix patch, then integrate the test into the
>>    parallel series.
>> else
>>    integrate both the fix and the test into the parallel series.
>>
>> @Randall please let us know if the fix proposed by Peff in the other
>> response works for you.
>
> It sounds sensible, but a standalone fix early before 2.54 final, as
> the problem and the fix shown by Peff here looked correct, without
> waiting for NonStop may be simpler to work with.  Then, rebuild
> parallel series on top of the 'master' that has the fix applied,
> perhaps?

Yes, that is the path forward now that Randall also confirmed the fix works on NonStop (btw thank you Randall). :)

Just waiting for Peff to tell me if he wants to send it himself.
Previous: rsbecker@nexbridge.comNext: Jeff King
Message 10 of 18 in “Help needed on 2.54.0-rc0 t5301.13 looping.”
  1. rsbecker@nexbridge.comApr 7, 2026
  2. Jeff KingApr 8, 2026
  3. Jeff KingApr 8, 2026
  4. Adrian RatiuApr 8, 2026
  5. rsbecker@nexbridge.comApr 8, 2026
  6. rsbecker@nexbridge.comApr 8, 2026
  7. rsbecker@nexbridge.comApr 8, 2026
  8. Junio C HamanoApr 8, 2026
  9. rsbecker@nexbridge.comApr 8, 2026
  10. Adrian RatiuApr 8, 2026
  11. t5401: test SIGPIPE with parallel hooksJeff King, Apr 8, 2026
  12. Junio C HamanoApr 8, 2026
  13. Adrian RatiuApr 8, 2026
  14. run_processes_parallel(): fix order of sigpipe handlingJeff King, Apr 8, 2026
  15. Junio C HamanoApr 8, 2026
  16. Junio C HamanoApr 8, 2026
  17. Jeff KingApr 8, 2026
  18. Junio C HamanoApr 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.