Re: [PATCH] git.el: Add a git-grep command

From: David Kågedal <davidk@lysator.liu.se>
Date: Feb 22, 2008, 09:18 UTC
Message-ID: <87tzk19wn5.fsf@lysator.liu.se>
In-Reply-To: <m3myptcqji.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 16 quoted lines

> David Kågedal <davidk@lysator.liu.se> writes:
>
>> This works for me, but before including it someone else should try
>> it. It might only work in Emacs 22, for instance.
>
> 1077:[emacs@git/contrib/emacs]# LC_ALL=en_EN make
> emacs -batch -f batch-byte-compile git.el
> Loading /usr/share/emacs/site-lisp/site-start.d/php-mode-init.el (source)...
> [...]
> While compiling toplevel forms in file /home/jnareb/git/contrib/emacs/git.el:
>   !! File error (("Cannot open load file" "grep"))
> Done
> make: *** [git.elc] Error 1
>
> 1078:[emacs@git/contrib/emacs]# emacs --version
> GNU Emacs 21.4.1

As I suspected. The problem is that the grep commands were rewritten for Emacs 22, and lots of it can be reused. So to write a similar command for Emacs 21 probably requires a bit more work. And since I use Emacs 22 I'm not sure I will feel motivated enough...

-- 
David Kågedal