Re: [Wishlist] could git tell which password it is asking when asking a password.
- From
Rémi Vanicat <vanicat@debian.org>
- Date
- Jul 1, 2011, 19:25 UTC
- Message-ID
- <87tyb5n6pk.dlv@debian.org>
- In-Reply-To
- <7vwrg1opov.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Shawn Pearce <spearce@spearce.org> writes:
>
>> On Fri, Jul 1, 2011 at 10:16, Junio C Hamano <gitster@pobox.com> wrote:
>>> Junio C Hamano <gitster@pobox.com> writes:
>>> diff --git a/http.c b/http.c
>>> index b2ae8de..44948a7 100644
>>> --- a/http.c
>>> +++ b/http.c
>>> @@ -209,8 +209,11 @@ static void init_curl_http_auth(CURL *result)
>>> {
>>> if (user_name) {
>>> struct strbuf up = STRBUF_INIT;
>>> - if (!user_pass)
>>> - user_pass = xstrdup(git_getpass("Password: "));
>>> + if (!user_pass) {
>>> + strbuf_addf(&up, "Password for %s: ", user_name);
>>
>> The user_name by itself may not be sufficient. I may also need the URL
>> to correctly answer the question. I don't always use the same password
>> on every website. :-)
>>
>> As a human sure, I know what URL I asked Git to poke for me.
>
> I was wondering about that when I gave that quick patch. And "as a human"
> may not necessarily apply when you are letting submodule fetch to recurse.I also believe that having the host name would be useful, both for human (another example would be git remote update when there are several remote) and script.
-- Rémi Vanicat