Re: [PATCH v2 2/2] tests: add a special setup where rebase.useBuiltin is off

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 14, 2018, 13:58 UTC
Message-ID: <87tvkj222w.fsf@evledraar.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1811141452520.39@tvgsbejvaqbjf.bet>

On Wed, Nov 14 2018, Johannes Schindelin wrote:

Show 17 quoted lines

> Hi Ævar,
>
> On Wed, 14 Nov 2018, Ævar Arnfjörð Bjarmason wrote:
>
>> Add a GIT_TEST_REBASE_USE_BUILTIN=false test mode which is equivalent
>> to running with rebase.useBuiltin=false. This is needed to spot that
>> we're not introducing any regressions in the legacy rebase version
>> while we're carrying both it and the new builtin version.
>>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> ---
>>  builtin/rebase.c | 5 ++++-
>>  t/README         | 4 ++++
>>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> I am slightly surprised not to see any ci/ change in this diffstat. Did
> you mean to add a test axis for Travis, or not?

No, but that's a logical follow-up by someone more familiar with the CI setup. I'm using this so I can test versions of "next" when building my own package.