Re: [PATCH] builtin/gc: warn when core.commitGraph is disabled
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 10, 2021, 11:55 UTC
- Message-ID
- <87tunau7ia.fsf@evledraar.gmail.com>
- In-Reply-To
- <510425b8b17411eb93770026b95c99cc@oschina.cn>
On Mon, May 10 2021, lilinchao@oschina.cn wrote:
> From: Li Linchao <lilinchao@oschina.cn> > > Throw warning message when core.commitGraph is disabled in commit-graph > maintenance task.
Won't this cause the gc.log issue noted in https://lore.kernel.org/git/87r1l27rae.fsf@evledraar.gmail.com/
More importantly, I don't think this UX makes sense. We said we didn't want it, so why warn about it?
Maybe there are good reasons to, but this commit message / patch doesn't make the case for it...
Show 21 quoted lines
> Signed-off-by: Li Linchao <lilinchao@oschina.cn>
> ---
> builtin/gc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/gc.c b/builtin/gc.c
> index 98a803196b..90684ca3b3 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -861,8 +861,10 @@ static int run_write_commit_graph(struct maintenance_run_opts *opts)
> static int maintenance_task_commit_graph(struct maintenance_run_opts *opts)
> {
> prepare_repo_settings(the_repository);
> - if (!the_repository->settings.core_commit_graph)
> + if (!the_repository->settings.core_commit_graph) {
> + warning(_("skipping commit-graph task because core.commitGraph is disabled"));
> return 0;
> + }
>
> close_object_store(the_repository->objects);
> if (run_write_commit_graph(opts)) {