Re: [PATCH] subtree: fix argument validation in add/pull/push

From: Thomas Rast <tr@thomasrast.ch>
Date: Nov 27, 2013, 19:19 UTC
Message-ID: <87siuhfy9q.fsf@thomasrast.ch>
In-Reply-To: <1385577249-29269-1-git-send-email-Anthony.Baire@irisa.fr>

Anthony Baire <Anthony.Baire@irisa.fr> writes:

> When working with a remote repository add/pull/push do not accept a
> <refspec> as parameter but just a <ref>. They should accept any
> well-formatted ref name.

[...]

>  - update the doc to use <ref> instead of <refspec>

[...]

Show 10 quoted lines

>  OPTS_SPEC="\
>  git subtree add   --prefix=<prefix> <commit>
> -git subtree add   --prefix=<prefix> <repository> <commit>
> +git subtree add   --prefix=<prefix> <repository> <ref>
>  git subtree merge --prefix=<prefix> <commit>
> -git subtree pull  --prefix=<prefix> <repository> <refspec...>
> -git subtree push  --prefix=<prefix> <repository> <refspec...>
> +git subtree pull  --prefix=<prefix> <repository> <ref>
> +git subtree push  --prefix=<prefix> <repository> <ref>
>  git subtree split --prefix=<prefix> <commit...>

[...]

Show 6 quoted lines

> @@ -68,7 +68,7 @@ COMMANDS
>  --------
>  add::
>  	Create the <prefix> subtree by importing its contents
> -	from the given <refspec> or <repository> and remote <refspec>.
> +	from the given <commit> or <repository> and remote <ref>.

AFAICS you are changing refspec->commit in the manpage, but commit->ref in the usage message for 'subtree add'? How does this line up?

-- 
Thomas Rast
tr@thomasrast.ch