Re: 2.20.0 - Undocumented change in submodule update wrt # parallel jobs
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Dec 13, 2018, 14:02 UTC
- Message-ID
- <87sgz11q4u.fsf@evledraar.gmail.com>
- In-Reply-To
- <CAHef355RQt9gN-7QjuAAT8mZsNFKfCo4hOYi2+bkp-0Av7W=Qw@mail.gmail.com>
On Thu, Dec 13 2018, Sjon Hortensius wrote:
Show 10 quoted lines
> When switching to 2.20 our `git submodule update' (which clones > through ssh) broke because our ssh-server rejected the ~20 > simultaneous connections the git-client makes. This seems to be caused > by a (possibly unintended) change in > https://github.com/git/git/commit/90efe595c53f4bb1851371344c35eff71f604d2b > which removed the default of max_jobs=1 > > While this can easily be fixed by configuring submodule.fetchJobs I > think this change should be documented - or reverted back to it's > previous default of 1
Just to add to this. SSH-ing with -j<ncores> (which I assume that ~20 is) is going to run into MaxStartups in sshd_config, which is especially annoying as it's pre-ssh-auth, so the server doesn't even get "so and so tried to login", it's just dropped as a potential DoS attack.