git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH guilt] Handles slashes in branch names

From
ELEric Lesh <eclesh@ucla.edu>
Date
Jul 19, 2007, 19:17 UTC
Message-ID
<87r6n4td8y.fsf@hubert.paunchy.net>
In-Reply-To
<20070719184418.GA22463@filer.fsl.cs.sunysb.edu>

When a branch name has a slash and autotagging is enabled, guilt barfs when updating the stack tags. Make these branch names work.

Also allow guilt to create the patches directory for these branches.
Signed-off-by: Eric Lesh <eclesh@ucla.edu>
---
Josef Sipek <jsipek@fsl.cs.sunysb.edu> writes:
Show 8 quoted lines
>
> Why mangle the branch name when we can do:
>
> mkdir -p `basename $GIT_DIR/refs/tags/${branch}_top`
> git-rev-parse .... 
>
> Sure, it is ugly, but it preserves the branch name. Am I missing something?
>
Yours is a lot less ugly than mine was.
 guilt      |    1 +
 guilt-init |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/guilt b/guilt
index 214def4..c913bd6 100755
--- a/guilt
+++ b/guilt
@@ -338,6 +338,7 @@ update_stack_tags()
 		# there are patches applied, therefore we must get the top,
 		# bottom and base hashes, and update the tags
 
+		mkdir -p `dirname $GIT_DIR/refs/tags/${branch}_top`
 		git-rev-parse HEAD > "$GIT_DIR/refs/tags/${branch}_top"
 		head -1 < $applied | cut -d: -f1 > "$GIT_DIR/refs/tags/${branch}_bottom"
 		git-rev-parse $(head -1 < $applied | cut -d: -f1)^ > "$GIT_DIR/refs/tags/${branch}_base"
diff --git a/guilt-init b/guilt-init
index ffe2434..9136f89 100755
--- a/guilt-init
+++ b/guilt-init
@@ -24,7 +24,7 @@ if [ -d "$GUILT_DIR/$branch" ]; then
 fi
 
 [ ! -d "$GUILT_DIR" ] && mkdir $GUILT_DIR
-mkdir $GUILT_DIR/$branch
+mkdir -p $GUILT_DIR/$branch
 touch $GUILT_DIR/$branch/series
 touch $GUILT_DIR/$branch/status
 
-- 
1.5.2
Previous: Josef SipekNext: Josef Sipek
Message 3 of 4 in “Handles slashes in branch names”
  1. Handles slashes in branch namesEric Lesh, Jul 19, 2007
  2. Josef SipekJul 19, 2007
  3. Handles slashes in branch namesEric Lesh, Jul 19, 2007
  4. Josef SipekJul 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.