Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

From: Frank Terbeck <ft@bewatermyfriend.org>
Date: Jul 1, 2010, 10:19 UTC
Message-ID: <87pqz7ec79.fsf@ft.bewatermyfriend.org>
In-Reply-To: <4C2C647F.7090909@drmicha.warpmail.net>

Michael J Gruber wrote: [...]

Show 12 quoted lines

>> And a unified diff of the two:
>> [snip]
>> --- trash directory.t9119-git-svn-info/actual.info-added-directory 2010-07-01 11:22:16.000000000 +0200
>> +++ trash directory.t9119-git-svn-info/expected.info-added-directory 2010-07-01 11:22:16.000000000 +0200
>> @@ -1,6 +1,7 @@
>>  Path: added-directory
>>  URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
>>  Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
>> +Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8
>
> "Nachtigall, ick hör Dir trapsen." [I really don't know how to translate
> this...]

No need. :)

Show 14 quoted lines

> Anyway, this is something I had fixed previously before realizing it
> doesn't need a fix and something else is wrong:
>
> It indicates that Git's svn-bindings (git-svn) use a different svn
> version than the actual "svn". (There used to be a bug where Git was
> wrong about the version of the bindings but that is fixed.)
>
> Do the following agree for you:
>
> git svn --version
> svn --version
>
> Do you have any private copies of svn/svn bindings in your path or perl
> path?

Okay, it wasn't really a private copy, but you're otherwise spot-on. Here's what was wrong:

I didn't realise, `git-svn' was using Perl's subversion bindings. This happens on my laptop which runs debian stable (lenny). I was upgrading my subversion package to the one provided by backports.org (a service that provides backports of newer versions of certain software packages to debian stable). While that worked nicely, the subversion bindings for Perl are provided by a package called `libsvn-perl' which was kept at the version in stable, which is 1.5.1. Backports.org also provides an upgrade for that package. Now both "svn --version" and "git svn --version" report the same subversion version and the test passes again.

Maybe it would be good if git-svn or maybe just the test suite checked whether subversion's and the Perl binding's version matched?

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925