Re: [PATCH 0/1] gpg-interface: add minTrustLevel as a configuration option

From: Hans Jerry Illikainen <hji@dyntopia.com>
Date: Dec 18, 2019, 23:59 UTC
Message-ID: <87pnglyylt.hji@dyntopia.com>
In-Reply-To: <xmqq4ky0j8ca.fsf@gitster-ct.c.googlers.com>

On Mon, Dec 16 2019, Junio C Hamano wrote:

Show 11 quoted lines

>> Unfortunately, it breaks backward-compatibility in two ways:
>>
>> 1. The default trust level is TRUST_UNDEFINED.  This is compatible with
>>    the old behavior of every code path *except* for
>>    verify_merge_signature() (since, again, it used to die()s on trust
>>    levels below TRUST_MARGINAL).
>
> This might be a bit problematic.  If we can keep the default
> behaviour identical to the code before this patch, while allowing
> the configuration to tweak the behaviour, that would have been
> more easily acceptable.

Done in v1.

Show 6 quoted lines

>> 2. The %G? format specifier no longer includes 'U' for signatures made
>>    with a key that is either TRUST_UNDEFINED or TRUST_NEVER.
>
> Hmm, I can sort-of-see why you want to introduce a new placeholder
> "%GT" to disambiguate two sources of 'U', but why would this change
> to "%G?" necessary?

U is re-introduced in v1. %GT is still there (since %G? doesn't print all trust levels) but I don't mind removing it (I added it for completeness sake when breaking backward-compatibility in v0).

-- 
hji