Re: [PATCH] ci: add job performing static analysis on GitLab CI

From: Toon Claes <toon@iotcl.com>
Date: Jan 4, 2024, 09:19 UTC
Message-ID: <87plyhfo00.fsf@iotcl.com>
In-Reply-To: <1536a5ef07ad24dafb5d685b40099882f89e6cc5.1703761005.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 20 quoted lines

> --- a/ci/install-docker-dependencies.sh
> +++ b/ci/install-docker-dependencies.sh
> @@ -21,7 +21,7 @@ linux-musl)
>  		apache2 apache2-http2 apache2-proxy apache2-ssl apache2-webdav apr-util-dbd_sqlite3 \
>  		bash cvs gnupg perl-cgi perl-dbd-sqlite >/dev/null
>  	;;
> -linux-*)
> +linux-*|StaticAnalysis)
>  	# Required so that apt doesn't wait for user input on certain packages.
>  	export DEBIAN_FRONTEND=noninteractive
>
> @@ -31,6 +31,11 @@ linux-*)
>  		perl-modules liberror-perl libauthen-sasl-perl libemail-valid-perl \
>  		libdbd-sqlite3-perl libio-socket-ssl-perl libnet-smtp-ssl-perl ${CC_PACKAGE:-${CC:-gcc}} \
>  		apache2 cvs cvsps gnupg libcgi-pm-perl subversion
> +
> +	if test "$jobname" = StaticAnalysis
> +	then
> +		apt install -q -y coccinelle
> +	fi

I was wondering why this was added, because I would assume the GitHub Workflow needed this too. Well, it seems the "StaticAnalysis" job for the Workflow runs ci/install-dependencies.sh instead of ci/install-docker-dependencies.sh. The ci/install-docker-dependencies.sh script is only used in the GitHub Workflow for the "dockerized" jobs. They set $jobname to "linux-musl", "linux32", and "pedantic", so this change is not affected by that.

Bottom line, changes all look good to me.

-- Toon