git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-gui: Add support of SHA256 repo

From
Takashi Iwai <tiwai@suse.de>
Date
Jul 16, 2025, 07:24 UTC
Message-ID
<87ple08upb.wl-tiwai@suse.de>
In-Reply-To
<c543a644-8e58-4601-8a79-247cd5e124c5@kdbg.org>

On Tue, 15 Jul 2025 21:19:38 +0200, Johannes Sixt wrote:

Show 22 quoted lines
> 
> Am 15.07.25 um 16:18 schrieb Takashi Iwai:
> > On Mon, 14 Jul 2025 18:28:13 +0200,
> >> BTW, there is a case
> >>
> >>       if {[regexp {^[0-9a-f]{1,39}$} $head]}
> >>
> >> around line 3217 in git-gui.sh.
> > 
> > Obviously I didn't look for numbers less than 40 :)
> > I'll replace it, too.
> > 
> > But I don't understand why it matches up to only 39, not 40 in the
> > code above.
> > It seems trying to get the proper hash id if it's no full length id?
> > If so, the check should be rather like
> > 	if {![regexp {^[0-9a-f]{40}$} $head]}
> > ??  It makes the conversion a bit simpler.
> 
> Obviously, the code wants to turn abbreviated hashes to full hashes.
> That can be skipped if it is already the full length. I haven't analyzed
> why this is needed or desirable.

Maybe it wants only the abbreviated hashes and no other refs? I'll keep the logic in v3 patch. If any, we can clean up later.

thanks,
Takashi
Previous: Johannes Sixt
Message 5 of 5 in “git-gui: Add support of SHA256 repo”
  1. git-gui: Add support of SHA256 repoTakashi Iwai, Jul 3, 2025
  2. Johannes SixtJul 14, 2025
  3. Takashi IwaiJul 15, 2025
  4. Johannes SixtJul 15, 2025
  5. Takashi IwaiJul 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.