Re: [PATCH] Add option --no-tags

From: Thomas Rast <tr@thomasrast.ch>
Date: Oct 30, 2013, 15:06 UTC
Message-ID: <87ob66g5m7.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <CAMXp-VP9DDJ-L=e=7=-bO+ZFVRMVz-PAs0gGv8Q7RrZ-OWof9Q@mail.gmail.com>

Nicolas Cornu <ncornu@aldebaran-robotics.com> writes:

Show 8 quoted lines

> From 1cbc2c49454581a67cce09ada1386dac4ffa2828 Mon Sep 17 00:00:00 2001
> From: Nicolas Cornu <ncornu@aldebaran-robotics.com>
> Date: Tue, 29 Oct 2013 11:31:10 +0100
> Subject: [PATCH] Add option --no-tags
>
> ---
>  gitk-git/gitk | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

This patch suffers from the same problems as the one for the horizontal scroll bar. In particular the commit message should (from Documentation/SubmittingPatches):

  . [explain] the problem the change tries to solve, iow, what is wrong
    with the current code without the change.

  . [justify] the way the change solves the problem, iow, why the
    result with the change is better.

  . [describe] alternate solutions considered but discarded, if any.

On the change itself: from a brief glance it seems you are trying to hide the tags shown alongside commits (presumably because there are too many).

However we already have one feature in a similar vein: the tickbox "Hide remote refs" in Edit->Preferences. Shouldn't your feature go alongside it, and be configured in the same way?

-- 
Thomas Rast
tr@thomasrast.ch