Re: [PATCH v3] stash: handle specifying stashes with spaces

From: Thomas Rast <tr@thomasrast.ch>
Date: Jan 7, 2014, 22:17 UTC
Message-ID: <87ob3nphc5.fsf@thomasrast.ch>
In-Reply-To: <xmqq7gabeiqo.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Øystein Walle <oystwa@gmail.com> writes:
>
>> +	git stash &&
>> +	test_tick &&
>> +	echo cow > file &&
>> +	git stash &&
>> +	git stash apply "stash@{Thu Apr 7 15:17:13 2005 -0700}" &&
>
> This is brittle.  If new tests are added before this, the test_tick
> will give you different timestamp and this test will start failing.
>
> Perhaps grab the timestamp out of the stash that was created [...]

Hmm, now that I stare at this, why not simply use something like

  git stash apply "stash@{ 0 }"

It seems to refer to the same as stash@{0} as one would expect, while still triggering the bug with unpatched git-stash.

-- 
Thomas Rast
tr@thomasrast.ch