Re: [PATCH] git-cvsserver.perl: encourage use of English module and qx() operator

From: Jari Aalto <jari.aalto@cante.net>
Date: Apr 16, 2010, 16:48 UTC
Message-ID: <87mxx3qr6y.fsf@jondo.cante.net>
In-Reply-To: <8639yve4gk.fsf@red.stonehenge.com>

merlyn@stonehenge.com (Randal L. Schwartz) writes:

Show 7 quoted lines

>>>>>> "jari" == jari aalto <jari.aalto@cante.net> writes:
>
> jari> Substitute magic variables $<puctuation> with the English.pm
>
> Please no.
>
> That might have been good advice in 2005, but it's crazy talk now.

It would be interesting to know why not. These magic variables are hard to read and remember without consulting the manual pages.

There doesn't seem to be noticeable performance penalty any more:

    $ perl --version | grep v5
    This is perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi

    $ time perl -e 'use English qw( -no_match_vars ); print'

    real    0m0.016s
    user    0m0.008s
    sys     0m0.004s

    $ time perl -e 'print 1'

    real    0m0.005s
    user    0m0.000s
    sys     0m0.004s

Jari