Re: [PATCH 0/3] subtree: add 'git-subtree-repo' and list command

From: David A. Greene <greened@obbligato.org>
Date: May 21, 2016, 22:59 UTC
Message-ID: <87mvnjow4n.fsf@waller.obbligato.org>
In-Reply-To: <1457603052-53963-1-git-send-email-npaolucci@atlassian.com>

Nicola Paolucci <npaolucci@atlassian.com> writes:

Show 5 quoted lines

> To my knowledge 'git subtree' currently lacks a way to
> track where injected repositories come from originally.
> Adding this information allows for useful extensions to 
> the command and makes it easier to use subtrees to track
> external dependencies.

Thanks for working on this. I just sent a reply to your earlier iteration.

What is the intent for use of this? Is it simply to record from where commits were pulled or do you intend to use this information later on to have git-subtree guess from where to fetch future commits?

I would be opposed to the latter because I think it potentially limits the utility of git-subtree and may be misleading. I frequently pull commits for a subtree from several different clones of the same reposiory. How does git-subtree list handle that situation?

Does git-subtree list really print out repository information for every commit added by git-subtree? That's potentially a lot of commits. It might be more useful to aggregate repository information and only dump out unique URLs. In any case, processing all commits seems like a ton of work for such a simple operation. Maybe this information should be cached in .gitconfig.

I'm actually in the middle of cleaing up metadata but I'm not going to block these commits due to that. Just be aware that it may change a bit.

                  -David