git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] update sha1dc from PR #36

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 27, 2017, 22:24 UTC
Message-ID
<87mv8tjchi.fsf@gmail.com>
In-Reply-To
<xmqqfuelyuuu.fsf@gitster.mtv.corp.google.com>
On Tue, Jun 27 2017, Junio C. Hamano jotted:
Show 9 quoted lines
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> A v2 addressing comments to the v1, tbdiff below. Just fixes the
>> subject line on 1/3 & gets rid of the redundant _BIG_ENDIAN detection
>> for Solaris, we can just use __sparc (and indeed we did before this).
>
> Thanks.  Let's have this tested by minority platform folks to help
> the upstream digest your pull request.  The change since the last
> round makes perfect sense to me.

I got someone on #cygwin on Freenode to test this for me (compile git + t0013-sha1dc.sh), it passed, ditto for 2x people testing on Solaris SPARC.

Updated a comment on the PR with that: https://github.com/cr-marcstevens/sha1collisiondetection/pull/36#issuecomment-311502713

I'm pretty sure this un-breaks everything & doesn't regress on cases where we fixed things earlier.

Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 7 of 9 in “update sha1dc from PR #36”
  1. 0/3 update sha1dc from PR #36Ævar Arnfjörð Bjarmason, Jun 27, 2017
  2. 1/3 sha1dc: correct endian detection for Solaris (and others?)Ævar Arnfjörð Bjarmason, Jun 27, 2017
  3. 2/3 sha1dc: optionally use sha1collisiondetection as a submoduleÆvar Arnfjörð Bjarmason, Jun 27, 2017
  4. 3/3 sha1collisiondetection: automatically enable when submodule is populatedÆvar Arnfjörð Bjarmason, Jun 27, 2017
  5. Junio C HamanoJun 27, 2017
  6. Junio C HamanoJun 27, 2017
  7. Ævar Arnfjörð BjarmasonJun 27, 2017
  8. Ævar Arnfjörð BjarmasonJun 28, 2017
  9. Junio C HamanoJun 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.