Re: [RFC PATCH] Introduce "precious" file concept

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 27, 2018, 15:08 UTC
Message-ID: <87mupuzhfx.fsf@evledraar.gmail.com>
In-Reply-To: <xmqqzhtwuhpc.fsf@gitster-ct.c.googlers.com>

On Mon, Nov 26 2018, Junio C Hamano wrote:

Show 16 quoted lines

> Per Lundberg <per.lundberg@hibox.tv> writes:
>
>> How about something like this:
>> ...
>> Would this be a reasonable compromise for everybody?
>
> I do not think you'd need to introduce such a deliberately breaking
> change at all.  Just introduce a new "precious" class, perhaps mark
> them with the atttribute mechanism, and that would be the endgame.
> Early adopters would start marking ignored but not expendable paths
> with the "precious" attribute and they won't be clobbered.  As the
> mechanism becomes widely known and mature, more and more people use
> it.  And even after that happens, early adopters do not have to change
> any attribute setting, and late adopters would have plenty of examples
> to imitate.  Those who do not need any "precious" class do not have
> to do anything and you won't break any existing automation that way.

The patch I submitted in <87zhuf3gs0.fsf@evledraar.gmail.com>[1] changed the behavior for read-tree & checkout & merge etc.

It was an RFC more in the spirit of showing what in our current tests had to change to spur some discussion.

But I'm very sympathetic to this line of argument. I.e. in my patch I'm changing the semantics of read-tree, which is plumbing.

What do you think about some patch like that which retains the plumbing behavior for things like read-tree, doesn't introduce "precious" or "trashable", and just makes you specify "[checkout|merge|...] --force" in cases where we'd have clobbering?

This would give scripts which relied on our stable plumbing consistent behavior, while helping users who're using our main porcelain not to lose data. I could then add a --force option to the likes of read-tree (on by default), so you could get porcelain-like behavior with --no-force.

1. https://public-inbox.org/git/87zhuf3gs0.fsf@evledraar.gmail.com/