Re: [PATCH] send-email: fix a "first config key wins" regression in v2.33.0

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 7, 2021, 09:15 UTC
Message-ID: <87mtoon3tc.fsf@evledraar.gmail.com>
In-Reply-To: <ce194f13-2b1f-fb21-e224-80190f3b2fd6@gmail.com>

On Mon, Sep 06 2021, Bagas Sanjaya wrote:

Show 18 quoted lines

> On 06/09/21 14.33, Ævar Arnfjörð Bjarmason wrote:
>> +test_expect_success $PREREQ 'sendemail.8bitEncoding in .git/config overrides --global .gitconfig' '
>> +	clean_fake_sendmail &&
>> +	git config sendemail.assume8bitEncoding UTF-8 &&
>> +	test_when_finished "rm -rf home" &&
>> +	mkdir home &&
>> +	git config -f home/.gitconfig sendemail.assume8bitEncoding "bogus too" &&
>> +	echo bogus |
>> +	env HOME="$(pwd)/home" DEBUG=1 \
>> +	git send-email --from=author@example.com --to=nobody@example.com \
>> +			--smtp-server="$(pwd)/fake.sendmail" \
>> +			email-using-8bit >stdout &&
>> +	egrep "Content|MIME" msgtxt1 >actual &&
>> +	test_cmp content-type-decl actual
>> +'
>> +
>
> Did you mean overrides global .gitconfig (s/--global/global/)?

I mean config set with the equivalent of "git config --global", but yeah this is probably an awkward way to phrase that.

> Anyway, compiled and tested successfully (test suite passed).
>
> Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>

Thanks, FWIW the test suite passing doesn't mean much in this case, the only test that stresses this is the above. The issue being that the regression wasn't caught by any existing test...