git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: diff-index --cc no longer permitted, gitk is now broken (slightly)

From
Sergey Organov <sorganov@gmail.com>
Date
Sep 18, 2021, 17:56 UTC
Message-ID
<87mto99398.fsf@osv.gnss.ru>
In-Reply-To
<87ee9n5cob.fsf@osv.gnss.ru>
Sergey Organov <sorganov@gmail.com> writes:
Show 35 quoted lines
> Philip Oakley <philipoakley@iee.email> writes:
>
>> On 17/09/2021 08:08, Sergey Organov wrote:
>>> Junio C Hamano <gitster@pobox.com> writes:
>>>
>>>> Sergey Organov <sorganov@gmail.com> writes:
>>>>
>>>>> I'm not sure I follow. What "show -p" has to do with "diff-index --cc"?
>>>>>
>>>>> My only point here is that usage of *--cc* in *diff-index* is entirely
>>>>> undocumneted, and that needs to be somehow resolved.
>>>> It was a response to your "historical status quo that is a problem."
>>>> I do not think there is any problem with "diff-index --cc" (except
>>>> for it wants a better documentation---but that we already agree) but
>>> Ah, now I see, but it's exactly lack of documentation (and tests) that I
>>> was referring to as the "problem of the historical status quo" on the
>>> Git side, so I was somewhat confused by your original response.
>>>
>>> Also, it's still unclear, even if not very essential, what exactly that
>>> "status quo" is when seen from the point of view of gitk. Does gitk
>>> actually utilize *particular output* of "diff-index --cc" for better, or
>>> gitk would be just as happy if it were synonym for "diff-index -p", or
>>> even if it'd be just as happy if --cc were silently consumed by
>>> diff-index?
>>
>> Did Johannes Sixt's earlier answer
>> https://lore.kernel.org/git/cbd0d173-ef17-576b-ab7a-465d42c82265@kdbg.org/
>> help clarify the choices?
>
> Sorry, no. I did read that carefully when it has been posted. Further
> explanations by Johannes also only tell that gitk expects --cc to be
> accepted by diff-index as it likes to treat multiple commands
> universally, but don't specify what output git expects from --cc when it
> passes it exactly to diff-index. Maybe it just shows the output and have
> no other expectations, dunno.

And, even more importantly, if gitk uses "git diff-index --cc" for its specific output, is there another, documented way to achieve the same goal?

Thanks, -- Sergey Organov

Previous: Sergey OrganovNext: Johannes Sixt
Message 28 of 29 in “diff-index --cc no longer permitted, gitk is now broken (slightly)”
  1. Johannes SixtAug 30, 2021
  2. Sergey OrganovAug 30, 2021
  3. Jeff KingAug 30, 2021
  4. Sergey OrganovAug 30, 2021
  5. Johannes SixtAug 30, 2021
  6. Sergey OrganovAug 30, 2021
  7. Junio C HamanoAug 30, 2021
  8. Sergey OrganovAug 30, 2021
  9. Junio C HamanoAug 30, 2021
  10. Sergey OrganovAug 30, 2021
  11. Sergey OrganovSep 1, 2021
  12. Junio C HamanoSep 7, 2021
  13. Sergey OrganovSep 7, 2021
  14. Sergey OrganovSep 8, 2021
  15. Johannes SixtSep 8, 2021
  16. Sergey OrganovSep 8, 2021
  17. Junio C HamanoSep 9, 2021
  18. Sergey OrganovSep 9, 2021
  19. Sergey OrganovSep 16, 2021
  20. Junio C HamanoSep 16, 2021
  21. Sergey OrganovSep 16, 2021
  22. Junio C HamanoSep 16, 2021
  23. Sergey OrganovSep 17, 2021
  24. Junio C HamanoSep 17, 2021
  25. Sergey OrganovSep 17, 2021
  26. Philip OakleySep 17, 2021
  27. Sergey OrganovSep 17, 2021
  28. Sergey OrganovSep 18, 2021
  29. Johannes SixtSep 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.