git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] negotiator/skipping: parse commit before queueing

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 27, 2018, 23:29 UTC
Message-ID
<87lg7miknk.fsf@evledraar.gmail.com>
In-Reply-To
<20180927231929.180599-1-jonathantanmy@google.com>
On Thu, Sep 27 2018, Jonathan Tan wrote:
Show 7 quoted lines
> The skipping negotiator pushes entries onto the priority queue without
> ensuring that the commit is parsed, resulting in the entry ending up in
> the wrong position due to a lack of commit time. Fix this by parsing the
> commit whenever we push an entry onto the priority queue.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
Thanks for the prompt fix!
Show 5 quoted lines
> This was noticed by Aevar in [1]. With this fix, 163 "have" lines are
> produced instead of the 14002 reported in [1].
>
> I have included a test to demonstrate the issue, but I'm not sure if
> it's worth including it in the source tree.

The test fails before the patch, and passes after, and tests that we do the right thing here. Seems best to include such tests whenever we can.

Previous: Jonathan Tan
Message 2 of 2 in “negotiator/skipping: parse commit before queueing”
  1. negotiator/skipping: parse commit before queueingJonathan Tan, Sep 27, 2018
  2. Ævar Arnfjörð BjarmasonSep 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.