Re: [PATCH 1/6] git-merge: clarify "usage" by adding "-m <msg>"
- From
Sergey Organov <sorganov@gmail.com>
- Date
- Oct 5, 2016, 20:41 UTC
- Message-ID
- <87k2dmr0j5.fsf@javad.com>
- In-Reply-To
- <xmqqint6pu3b.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 31 quoted lines
> sorganov@gmail.com writes:
>
>> From: Sergey Organov <sorganov@gmail.com>
>>
>> "-m <msg>" is one of essential distinctions between obsolete
>> invocation form and the recent one. Add it to the "usage" returned by
>> 'git merge -h' for more clarity.
>>
>> Signed-off-by: Sergey Organov <sorganov@gmail.com>
>> ---
>> builtin/merge.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/merge.c b/builtin/merge.c
>> index a8b57c7..0e367ba 100644
>> --- a/builtin/merge.c
>> +++ b/builtin/merge.c
>> @@ -43,7 +43,7 @@ struct strategy {
>> };
>>
>> static const char * const builtin_merge_usage[] = {
>> - N_("git merge [<options>] [<commit>...]"),
>> + N_("git merge [<options>] [-m <msg>] [<commit>...]"),
>> N_("git merge [<options>] <msg> HEAD <commit>"),
>> N_("git merge --abort"),
>> NULL
>
> While this is not wrong per-se, as the deprecated form will go away
> soon, I hope you do not mind if I had to drop this one from the
> series to avoid merge conflicts to 'pu' (I do not know how bad the
> conflict would be yet; I am just reviewing in my MUA).Yeah, sure. I was not aware obsolete form description is to go away soon.