git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] stash: document stash.useBuiltin

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
May 14, 2019, 09:44 UTC
Message-ID
<87k1etwesp.fsf@evledraar.gmail.com>
In-Reply-To
<6c250451658f34c1415bfcba35ee6303cecac0dc.1557825553.git.gitgitgadget@gmail.com>
On Tue, May 14 2019, Johannes Schindelin via GitGitGadget wrote:
Show 39 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The stash.useBuiltin variable introduced in 90a462725e ("stash:
> optionally use the scripted version again", 2019-02-25) was turned on by
> default, but had no documentation.
>
> Let's document it so that users who run into any stability issues with
> the C rewrite know there's an escape hatch, and spell out that the
> user should please report the bug when they have to turn off the
> built-in stash.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  Documentation/config/stash.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/config/stash.txt b/Documentation/config/stash.txt
> index c583d46d6b..d7bf6ec61f 100644
> --- a/Documentation/config/stash.txt
> +++ b/Documentation/config/stash.txt
> @@ -1,3 +1,18 @@
> +stash.useBuiltin::
> +       Set to `false` to use the legacy shell script implementation of
> +       linkgit:git-stash[1]. Is `true` by default, which means use
> +       the built-in rewrite of it in C.
> ++
> +The C rewrite is first included with Git version 2.22 (and Git for Windows
> +version 2.19). This option serves an an escape hatch to re-enable the
> +legacy version in case any bugs are found in the rewrite. This option and
> +the shell script version of linkgit:git-stash[1] will be removed in some
> +future release.
> ++
> +If you find some reason to set this option to `false` other than
> +one-off testing you should report the behavior difference as a bug in
> +git (see https://git-scm.com/community for details).
> +
>  stash.showPatch::
>  	If this is set to true, the `git stash show` command without an
>  	option will show the stash entry in patch form.  Defaults to false.
Thanks for following up on this. LGTM.
Previous: Johannes Schindelin via GitGitGadgetNext: Junio C Hamano
Message 3 of 8 in “Document the stash.useBuiltin escape hatch”
  1. 0/1 Document the stash.useBuiltin escape hatchJohannes Schindelin via GitGitGadget, May 14, 2019
  2. 1/1 stash: document stash.useBuiltinJohannes Schindelin via GitGitGadget, May 14, 2019
  3. Ævar Arnfjörð BjarmasonMay 14, 2019
  4. Junio C HamanoMay 15, 2019
  5. Eric SunshineMay 14, 2019
  6. Johannes SchindelinMay 15, 2019
  7. Junio C HamanoMay 15, 2019
  8. Johannes SchindelinMay 17, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.