git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsck: reject misconfigured fsck.skipList

From
Toon Claes <toon@iotcl.com>
Date
Jan 9, 2025, 08:00 UTC
Message-ID
<87jzb4ju2j.fsf@iotcl.com>
In-Reply-To
<xmqqttaatu8h.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
>
> If the value is missing, i.e.,
>
> 	[fsck]
> 		skipList
>
> it is a very clear misconfiguration.  "We expect a path, but you
> gave me a valueless true".  Once a specified value gets to
> oidset_parse_file(), we would die when a specified path cannot be
> opened, so it is not like we want to deliberately tolerate
> misconfiguration (we also die if the value is given as "~t/sl" and
> user "t" does not exist on the system).
>
> Makes sense.

Yeah, I did some testing as well and reviewed the code. Also makes sense to me.

-- Toon

Previous: Junio C Hamano
Message 3 of 3 in “fsck: reject misconfigured fsck.skipList”
  1. fsck: reject misconfigured fsck.skipListJustin Tobler, Jan 7, 2025
  2. Junio C HamanoJan 7, 2025
  3. Toon ClaesJan 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.