Re: [PATCH 2/4] git-gui: add smart case search mode in searchbar

From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Oct 17, 2011, 23:29 UTC
Message-ID: <87ipnngpsj.fsf@fox.patthoyts.tk>
In-Reply-To: <CAKPyHN2XQYrGDhfjX4G12Ggw6DuJasuYbLQvfbmikBbMezp4=g@mail.gmail.com>

Bert Wesarg <bert.wesarg@googlemail.com> writes:

Show 16 quoted lines

>On Mon, Oct 17, 2011 at 00:32, Andrew Ardill <andrew.ardill@gmail.com> wrote:
>> I don't really know tcl so I'm not certain, but it looks like you
>> never reset the case sensitive flag once it has been set by entering
>> an upper case letter. If I accidentally enter an upper case letter and
>> have set smartcase true, I would expect that deleting that character
>> would turn case sensitivity off again.
>>
>
>I never reset it, because your case is a way to search case-sensitive
>for an expression in all lower-case. For example, if you would like to
>search for 'git' case-sensitively, you would type: 'gitA^H'. A direct
>shortcut to toggle the case flag could also be of use. The other idea
>which come to mind, is to reset the case flag, if you clear the input
>field. I.e. type 'G^Hgit' would still seach case-insensitive.
>
>Bert

I don't really like the way it works at the moment. It seems very keen to enable the case sensitive mode and you must use the mouse to disable that. I see why you chose to make it work that way though. I think resetting it in clearing the field makes sense.

The rest of the series looks good. The history recording is nice to have.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD