Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 7, 2018, 07:20 UTC
Message-ID: <87in3hrcya.fsf@evledraar.gmail.com>
In-Reply-To: <20180907063241.GA172953@aiede.svl.corp.google.com>

On Fri, Sep 07 2018, Jonathan Nieder wrote:

Show 10 quoted lines

> Jeff King wrote:
>
>> I don't see any point in generating a sorted list and _then_ making an
>> auxiliary hashmap. My idea was that if you're using a sorted string-list
>> for lookup, then you can replace the whole thing with a hash (inserting
>> as you go, rather than sorting at the end).
>
> What if I'm sorting a string list in preparation for emitting a sorted
> list, and I *also* want to perform lookups in that same list?  In
> other words:

If this turns out to be a common use-case perhaps the easiest way to support that would be to make the hashmap (optionally?) ordered, as Ruby 1.9 did with their hash implementation: https://www.igvita.com/2009/02/04/ruby-19-internals-ordered-hash/